Add tag_name to update_release documentation #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [edit_release](https://developer.github.com/v3/repos/releases/#edit-a-release) endpoint accepts a tag_name so that should be documented here. Furthermore, when using the `update_release` method without specifying a tag_name, the tag in Github is overwritten. For example, my tag was "v4.0" and after calling `update_release` without a tag name it became "untagged-{commit-hash}".
|
Thanks for the contribution @smeriwether !!
I don't think that's the behavior, are you able to reproduce this using curl? It may work differently depending on whether the tag is published or unpublished. |
|
This has been released as part of https://github.com/octokit/octokit.rb/releases/tag/v4.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edit_release endpoint accepts a tag_name so that should be documented here.
Furthermore, when using the
update_releasemethod without specifying a tag_name, the tag in Github is overwritten.For example, my tag was "v4.0" and after calling
update_releasewithout a tag name it became "untagged-{commit-hash}".