Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix prettier usage #352

Merged
merged 1 commit into from
Sep 22, 2023
Merged

build: fix prettier usage #352

merged 1 commit into from
Sep 22, 2023

Conversation

wolfy1339
Copy link
Member

Prettier is async since v3
This unblocks automated updates

Resolves #ISSUE_NUMBER


Before the change?

  • The build scripts would fail because fs.writeFile() was receiving a Promise

After the change?

  • await the call to prettier

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Prettier is async since v3
This unblocks automated updates
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 22, 2023
@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 merged commit fe2cb84 into main Sep 22, 2023
7 checks passed
@wolfy1339 wolfy1339 deleted the fix-scripts branch September 22, 2023 22:22
@octokitbot
Copy link
Contributor

wolfy1339 added a commit that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants