feat(typescript): typescript definitions #396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
added
Type: Feature
gr2m
force-pushed
the
84/typescript-definitions
branch
from
8164819 to
303e650
Compare
40 tasks
|
This is solved in the WIP https://github.com/octokit/octokit-next.js. No endpoints types are loaded by default, they have to be loaded explicitly, e.g. I'm not sure if it is worth the effort to to continue working on this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #84
We currently only maintain the Endpoint types for api.github.com in
@octokit/types/src/generated/Endpoints.ts. Ideally we would start generating endpoint types for all GHES versions and GHAE, but that will be a bigger effort. For the time being it might be worth to figure out a workaround to unblock this pull request