Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump octokit/types.ts to v8.1.0 #534

Closed
wants to merge 1 commit into from
Closed

Bump octokit/types.ts to v8.1.0 #534

wants to merge 1 commit into from

Conversation

octokitbot
Copy link
Collaborator

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first. The @octokit/types should be updated automatically shortly after in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 11, 2023
@kfcampbell kfcampbell changed the title 🚧 GitHub OpenAPI specifications changed Bump octokit/types.ts to v8.1.0 Jan 11, 2023
@kfcampbell
Copy link
Member

Hmm...this is broken on main for me as well, which is interesting as #533 didn't see these issues on its merge to main.

@nickfloyd
Copy link
Contributor

This is breaking b/c of previews. I can take a stab at cleaning the test house so that we can move forward on this.

@nickfloyd
Copy link
Contributor

Closing this due to the revert here: octokit/types.ts#495

@nickfloyd nickfloyd closed this Jan 13, 2023
@nickfloyd nickfloyd deleted the openapi-update branch January 13, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants