Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deprecation): octokit.orgs.enableOrDisableSecurityProductOnAllOrgRepos(), octokit.projects.getCard(), octokit.projects.updateCard(), octokit.teams.addOrUpdateRepoPermissionsInOrg(), octokit.teams.listChildInOrg(), octokit.teams.removeRepoInOrg() endpoints deprecated, octokit.projects.deleteCard() endpoint updated #625

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

octokitbot
Copy link
Collaborator

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first. The @octokit/types should be updated automatically shortly after in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Nov 21, 2023
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd added the Type: Breaking change Used to note any change that requires a major version bump label Nov 28, 2023
@nickfloyd nickfloyd changed the title 🚧 GitHub OpenAPI specifications changed feat(deprecation) octokit.orgs.enableOrDisableSecurityProductOnAllOrgRepos(), octokit.projects.getCard(), octokit.projects.updateCard(), octokit.teams.addOrUpdateRepoPermissionsInOrg(), octokit.teams.listChildInOrg(), octokit.teams.removeRepoInOrg() endpoints deprecated, octokit.projects.deleteCard() endpoint updated Nov 28, 2023
@nickfloyd nickfloyd changed the title feat(deprecation) octokit.orgs.enableOrDisableSecurityProductOnAllOrgRepos(), octokit.projects.getCard(), octokit.projects.updateCard(), octokit.teams.addOrUpdateRepoPermissionsInOrg(), octokit.teams.listChildInOrg(), octokit.teams.removeRepoInOrg() endpoints deprecated, octokit.projects.deleteCard() endpoint updated feat(deprecation): octokit.orgs.enableOrDisableSecurityProductOnAllOrgRepos(), octokit.projects.getCard(), octokit.projects.updateCard(), octokit.teams.addOrUpdateRepoPermissionsInOrg(), octokit.teams.listChildInOrg(), octokit.teams.removeRepoInOrg() endpoints deprecated, octokit.projects.deleteCard() endpoint updated Nov 28, 2023
@nickfloyd nickfloyd merged commit 9b49db7 into main Nov 28, 2023
8 checks passed
@nickfloyd nickfloyd deleted the openapi-update branch November 28, 2023 17:23
Copy link
Contributor

🎉 This PR is included in version 15.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Eddman Eddman mentioned this pull request Feb 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants