Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): bump octokit/types for types for request.request.signal #716

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

octokitbot
Copy link
Collaborator

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first. The @octokit/types should be updated automatically shortly after in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 27, 2024
@kfcampbell kfcampbell changed the title 🚧 GitHub OpenAPI specifications changed fix(typescript): add types for request.request.signal Sep 27, 2024
@kfcampbell kfcampbell changed the title fix(typescript): add types for request.request.signal fix(typescript): bump octokit/types for types for request.request.signal Sep 27, 2024
@kfcampbell kfcampbell merged commit 4b2fdfa into main Sep 27, 2024
9 checks passed
@kfcampbell kfcampbell deleted the openapi-update branch September 27, 2024 19:06
Copy link
Contributor

🎉 This PR is included in version 17.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants