peer dependency issues

[dacbd]

Hi all, I recently went through some package updating in a project, and found that you have updated your ocktokit/core to v4 on v2.21.2 and then did a subsequent v3 that dropped the old node version support. Shouldn't that peer update have happened in your v3 release and not as a final patch release on v2?

I can probably work on my own updates to fix the npm install issue, but it is inconvenient.

[wolfy1339]

Yes, it should have happened in the v3 release.

Can you pin the version to 2.21.1? The 2.21.2 update didn't contain any other updates

[dacbd]

it wasn't directly installed, but a minimal example is:

{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@actions/github": "4.x",
    "@octokit/core": "3.x"
  }
}

[dacbd]

@wolfy1339 requiring and pining to 2.21.1 did resolve the issue

[oscard0m]

Should we close this issue @dacbd ?

@wolfy1339 do you want me to edit https://github.com/octokit/plugin-paginate-rest.js/releases/v2.21.2 Release notes to add alert users about this?

[dacbd]

@oscard0m I'd say if you can npm install the example package.json above without an npm WARN ERESOLVE overriding peer dependency then sure we can close it, but until then I would prefer it stay open.

[github-actions]

🎉 This issue has been resolved in version 2.21.3 🎉

The release is available on:

• GitHub release
• npm package (@release-2.x dist-tag)

Your semantic-release bot 📦🚀

[gr2m]

@dacbd can you confirm that the problem is resolved please?

[dacbd]

@gr2m confirmed the problem is resolved, thanks for all the responses team! ❤️