feat: add support for pagination in GET /orgs/{org_id}/codespaces
#397
Conversation
octokitbot
added
the
Type: Maintenance
| "url": "/repos/{owner}/{repo}/actions/caches", | ||
| "id": "get-actions-cache-list", | ||
| "scope": "actions", | ||
| "documentationUrl": "https://docs.github.com/rest/actions/cache#list-github-actions-caches-for-a-repository", |
There was a problem hiding this comment.
@gr2m It's curious that we don't seem to recognise this new API as paginated. I'll merge anyway - but I guess we will want to come back to this.
There was a problem hiding this comment.
Looks like the issue here is the operation ID. How do you reckon we should fix that at this point? Should we suggest that the owning team fixes it? Or maybe we should update our logic (e.g. look for the per_page param instead as well)?
timrogers
changed the title
GET /orgs/{org_id}/codespaces
|
@gr2m Any idea what is going on with the tests here? Is it the weird Typescript issues we've been having? |
problem was caused by a recent change in fyi @kachick |
|
🎉 This PR is included in version 2.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
If there are any new endpoints, then the code changes will likely required an update of
@octokit/types. It should have received a pull request as well, merge & release it first. The@octokit/typesshould be updated automatically shortly after in this pull request.Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.
In general
docsprefixfix(typescript)prefixfixif a problem was resolved,featif new endpoints / parameters were added, andfeat(deprecation)if a method was deprecated.