Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v8 #650

Merged
merged 3 commits into from
Jun 20, 2023
Merged

feat: v8 #650

merged 3 commits into from
Jun 20, 2023

Conversation

wolfy1339
Copy link
Member

BREAKING CHANGE: Drop support for NodeJS v14, v16

@wolfy1339
ci: stop testing against NodeJS v14, v16 (#637)
b451e6e 
* build(package): set minimal node version in engines field to v18
BREAKING CHANGE: Drop support for NodeJS v14, v16
@wolfy1339 wolfy1339 added Type: Feature New feature or request Type: Breaking change Used to note any change that requires a major version bump labels Jun 12, 2023
kfcampbell
kfcampbell previously approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only Octokit dependency here is core.js, whose Node 14 and 16 deprecation has yet to be released. Regardless, I think this PR is ready to go.

@kfcampbell kfcampbell mentioned this pull request Jun 12, 2023
Merged
@gr2m
Copy link
Contributor

gr2m commented Jun 12, 2023 •
edited
Loading

The only Octokit dependency here is core.js

it's a dev dependency, only used for testing

@kfcampbell kfcampbell marked this pull request as ready for review June 13, 2023 17:23
@kfcampbell
Copy link
Member

@wolfy1339 any objections to me merging this PR now?

@kfcampbell
Copy link
Member

I've fixed the merge conflict in package-lock.json. I think this will be good to ship as soon as the builds are ready.

kfcampbell
kfcampbell approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfy1339 feel free to merge when ready! I think this is good to go, right?

@wolfy1339
Copy link
Member Author

wolfy1339 commented Jun 20, 2023 •
edited
Loading

It shouldn't cause any issues. I think it's good to go. Although it's going to have a dependency on a beta version of @octokit/core (only dev dependency) which will get upgraded by renovate as soon as the stable version is released

@gr2m gr2m merged commit ecf360f into main Jun 20, 2023
@github-actions
Copy link
Contributor

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfy1339 @gr2m @kfcampbell