Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump Octokit dependencies to fix Deno compat #780

Closed
wants to merge 1 commit into from

Conversation

wolfy1339
Copy link
Member

See octokit/octokit.js#2762 (comment)

Resolves #ISSUE_NUMBER


Before the change?

  • Types would include a reference to @types/node even though there is nothing using Node specific APIs in the types

After the change?

  • Update @octokit/types to make sure types are platform agnostic
  • Update all Octokit dependencies to their latest version to ensure we pull in the latest version of @octokit/types

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member Author

@gr2m @kfcampbell @nickfloyd This will require merging from an administrator. The test failures are unrelated to this PR, and are due to some Syntax Errors in the JSON of the OpenAPI spec, see octokit/openapi#474 for the fix.
These type updates don't contain any new endpoints.

@oscard0m
Copy link
Member

oscard0m commented Jan 8, 2025

@gr2m @kfcampbell @nickfloyd This will require merging from an administrator. The test failures are unrelated to this PR, and are due to some Syntax Errors in the JSON of the OpenAPI spec, see octokit/openapi#474 for the fix. These type updates don't contain any new endpoints.

Where can I read more about this @wolfy1339? I don't get what as this error to do with the PR you linked:

file:///home/runner/work/plugin-rest-endpoint-methods.js/plugin-rest-endpoint-methods.js/scripts/update-endpoints/fetch-json.mjs:72
    data: { endpoints },
            ^

TypeError: Cannot read properties of null (reading 'endpoints')
    at main (file:///home/runner/work/plugin-rest-endpoint-methods.js/plugin-rest-endpoint-methods.js/scripts/update-endpoints/fetch-json.mjs:72:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

Node.js v[22](https://github.com/octokit/plugin-rest-endpoint-methods.js/actions/runs/12673697384/job/35320684307?pr=780#step:7:23).12.0

@wolfy1339
Copy link
Member Author

There was a Syntax Error in version 17.0.0 of the Octokit OpenAPI spec, I'm assuming it has something to do with that

@wolfy1339 wolfy1339 closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants