Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect types: Could not find a declaration file for module '@octokit/plugin-throttling' #583

Closed
leeuwd opened this issue Apr 20, 2023 · 3 comments · Fixed by #584
Closed

Incorrect types: Could not find a declaration file for module '@octokit/plugin-throttling' #583

leeuwd opened this issue Apr 20, 2023 · 3 comments · Fixed by #584
Labels
released Type: Bug Something isn't working as documented

Comments

@leeuwd
Copy link

leeuwd commented Apr 20, 2023

IDE/buid error when using@octokit/plugin-throttling@5.1.0 in Next.js 13 and TypeScript 5.0.4:

Type error: Could not find a declaration file for module '@octokit/plugin-throttling'. '[redacted]/node_modules/@octokit/plugin-throttling/dist-node/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/octokit__plugin-throttling` if it exists or add a new declaration (.d.ts) file containing `declare module '@octokit/plugin-throttling';`
@wolfy1339 wolfy1339 added Priority: High Type: Bug Something isn't working as documented labels Apr 20, 2023
@pragmaticivan
Copy link

I can replicate that.

wolfy1339 added a commit that referenced this issue Apr 20, 2023
@wolfy1339
fix(build): add script to fix package.json from build step
2e95888 
Fixes #583
@wolfy1339 wolfy1339 mentioned this issue Apr 20, 2023
Merged
5 tasks
@Mause Mause mentioned this issue Apr 21, 2023
Merged
1 task
HeavenlyEntity added a commit to HeavenlyEntity/plugin-throttling.js that referenced this issue Apr 21, 2023
@HeavenlyEntity
🚑 Fixed root entrance error
4b97ce1 
Organized types, optimized their application and removed old types file as if project continues to scale. Types would be better identified in a folder basis.

octokit#584
octokit#583
octokit#106 - Related by setting up tests for proper editing. As before users could not test properly due to project configuration. Will come back to this one once the FATAL error above is confirmed fixed after new release.
@HeavenlyEntity HeavenlyEntity mentioned this issue Apr 21, 2023
Closed
@wolfy1339
Copy link
Member

There are 2 reasons for this issue.

  1. npm changed the file matching code
  2. Our build system is no longer maintained and has been archived since April 2022

See npm/cli#6164 and #525 for details

wolfy1339 added a commit that referenced this issue Apr 21, 2023
@wolfy1339
fix(build): add script to fix package.json from build step (#584)
e7f99d0 
Fixes #583
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): add script to fix package.json from build step octokit/plugin-throttling.js
3 participants
@pragmaticivan @leeuwd @wolfy1339