Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM package missing dist files #337

Closed
1 task done
wolfy1339 opened this issue Jun 1, 2023 · 3 comments · Fixed by #338
Closed
1 task done

NPM package missing dist files #337

wolfy1339 opened this issue Jun 1, 2023 · 3 comments · Fixed by #338
Assignees
@wolfy1339
Labels
released Type: Bug Something isn't working as documented

Comments

@wolfy1339
Copy link
Member

What happened?

Only dist-node seems to be included in the release, which means there are no types

Versions

V4.0.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@wolfy1339 wolfy1339 added Priority: High Type: Bug Something isn't working as documented labels Jun 1, 2023
@wolfy1339 wolfy1339 self-assigned this Jun 1, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Jun 1, 2023
@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🏗 In progress in 🧰 Octokit Active Jun 1, 2023
@wolfy1339
Copy link
Member Author

See octokit/octokit.js#2464 (comment)

@wolfy1339 wolfy1339 mentioned this issue Jun 1, 2023
Closed
1 task
@kfcampbell
Copy link
Member

kfcampbell commented Jun 1, 2023 •
edited
Loading

@wolfy1339 I can help roll out esbuild. Once oauth-authorization-url.js#279 has been confirmed to fix the problem, I can replicate that fix across the other 22 instances I see in octokit-owned orgs.

@wolfy1339 wolfy1339 mentioned this issue Jun 2, 2023
Merged
5 tasks
@gr2m gr2m closed this as completed in #338 Jun 2, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This issue has been resolved in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolfy1339 wolfy1339

Labels
released Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): switch to esbuild octokit/request-error.js
2 participants
@wolfy1339 @kfcampbell