fix(build): switch to esbuild and tsc

[kfcampbell]

Replicating octokit/request.js#584 to another repo.

Consumers of this module such as oauth-methods.js#152 are seeing missing types. This PR attempts to fix that issue by getting us off of pika before additional Node deprecations can be made.

Note that when running npm run build locally, I see the following errors:

 sh$ npm run build

> @octokit/oauth-authorization-url@0.0.0-development build
> node scripts/build.mjs && tsc -p tsconfig.json

✘ [ERROR] Could not resolve "./types"

    pkg/dist-src/index.js:7:7:
      7 │ } from "./types";
        ╵        ~~~~~~~~~

✘ [ERROR] Could not resolve "./types"

    pkg/dist-src/index.js:7:7:
      7 │ } from "./types";
        ╵        ~~~~~~~~~

These errors are not present in the CI build because npm run build does not appear to be run then. I believe this to be a configuration issue and I think I missed something in this repo to get this to function correctly. Tips are appreciated!

---

Pika has been deprecated for a while now, and the project has now been archived, and because of that the released npm package is missing most of the files generated by the build step.

Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle

Uses the TypeScript compiler to generate the types.

Behavior

Before the change?

• Uses pika for the build system
• The released npm package is missing most of the files generated by the build step. dist-node, dist-types, dist-web... even though they are generated correctly.

After the change?

• Uses esbuild to generate the JS bundles
• Uses the TypeScript compiler to generate the type definitions
• The correct file matching patterns are used so we publish all the necessary files again.

---

Additional info

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes (Please add the Type: Breaking change label)
• No

If Yes, what's the impact:

• N/A

Pull request type

Please add the corresponding label for change this PR introduces:

• Bugfix: Type: Bug
• Dependencies/code cleanup: Type: Maintenance

---

[wolfy1339]

Some quick things I noticed

[wolfy1339]

The errors are because you need to explicitly mark type imports/exports

[kfcampbell]

@wolfy1339 thanks for the tip! After applying your changes I'm still seeing the same errors...is there another spot where an import/export is missed?

[wolfy1339]

There probably are more places in the code that need updating

[kfcampbell]

Aha! Here is what was missing. npm run build succeeds for me locally and I think this is ready to go.

[wolfy1339]

LGTM, some small style issues.

[github-actions]

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀