-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: surface 'cause' for undici network errors #642
fix: surface 'cause' for undici network errors #642
Conversation
great PR, thank you!!! It looks like coverage dropped, could you please have a look?
|
The line is covered but not all branches (possible execution paths) are. I think it's ok to ignore the line from coverage. I'm out on mobile right now, I forgot the syntax for jest coverage |
Aha just figured that out at the same time. Just pushed up a fix. Thanks! |
🎉 This PR is included in version 8.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #641
Before the change?
Network errors from undici are presented with "fetch failed" without showing the underlying cause that undici also presents.
After the change?
Network errors now correctly propagate the 'cause' from undici
Pull request checklist
Does this introduce a breaking change?