Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT]: Breaking change released under a patch version #318

Closed
1 task done
JoaoBGusmao opened this issue Jun 16, 2023 · 9 comments · Fixed by #320 · 4 remaining pull requests
Closed
1 task done

[MAINT]: Breaking change released under a patch version #318

JoaoBGusmao opened this issue Jun 16, 2023 · 9 comments · Fixed by #320 · 4 remaining pull requests
Labels
released on @beta released on @19.x released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@JoaoBGusmao
Copy link

Describe the need

I'm sadly tied to node 14 due to the complexity to update to node 18.
I'm using lerna, that installs @octokit/rest, that installs @octokit/plugin-paginate-rest.
@octokit/plugin-paginate-rest 6 to 7 introduced a breaking change related to node version, and this library just updated from 6.1.2 to 7.0.0 but published this change to 19.0.12 instead of 20.x.
It should have been published under 20.x as this change inherits the breaking change from @octokit/plugin-paginate-rest

SDK Version

No response

API Version

No response

Relevant log output

➜  libs yarn add lerna@6.4.1
yarn add v1.22.19
[1/4] 🔍  Resolving packages...
warning lerna > @lerna/bootstrap > @npmcli/arborist > @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
warning lerna > @lerna/create > pacote > cacache > @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
warning lerna > @lerna/bootstrap > @npmcli/arborist > readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
[2/4] 🚚  Fetching packages...
error @octokit/plugin-paginate-rest@7.1.2: The engine "node" is incompatible with this module. Expected version ">= 18". Got "14.17.6"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@JoaoBGusmao JoaoBGusmao added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Jun 16, 2023
@colinperepelken
Copy link

We are experiencing this issue as well. yarn global add lerna@5 fails with:

[2/4] Fetching packages...
error @octokit/plugin-paginate-rest@7.1.2: The engine "node" is incompatible with this module. Expected version ">= 18". Got "14.21.3"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.

This is blocking all of our CircleCI workflows unfortunately.

@wolfy1339 wolfy1339 added Priority: Critical and removed Status: Triage This is being looked at and prioritized labels Jun 16, 2023
@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Jun 16, 2023
@colinperepelken
Copy link

colinperepelken commented Jun 16, 2023

As a temporary workaround, we are installing lerna at version 5.1.8 instead, as lerna bumped @octokit/rest from v18 -> v19 in 5.2.0

wolfy1339 pushed a commit that referenced this issue Jun 16, 2023
Fixes #318 and removes the breaking dependency changes that prematurely
dropped support for Node 14/16.
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Jun 16, 2023
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 19.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gavacq
Copy link

gavacq commented Jun 16, 2023

We're still seeing this error when installing lerna@5, but from another octokit package:
error @octokit/request-error@4.0.2: The engine "node" is incompatible with this module. Expected version ">= 18". Got "14.21.3"

@wolfy1339
Copy link
Member

Missed that one. Filed a bug, and will get to working on it ASAP octokit/request.js#596

@wolfy1339
Copy link
Member

@gavacq It should be reverted now. It should be the last of `em to revert

@gavacq
Copy link

gavacq commented Jun 16, 2023

Confirmed I can install lerna@5 on node 14 now. Thanks!

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 20.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

🎉 This issue has been resolved in version 19.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released on @19.x released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
4 participants