Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: remove previews (#491)" #495

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

nickfloyd
Copy link
Contributor

This reverts commit cb0835b.

This reverts #491 because removing the previews logic broke the build for our enterprise modules such as plugin-enterprise-server.js, because of old versions of GHE such as v3.2 and v3.3 (set to be deprecated next week).

Also, because GraaphQL previews are not deprecated yet @octokit/core, @octokit/graphql, and octokit.js will need to be modified.

I missed these things in my review, which is why I am reverting this changeset; so that we can modify the other libraries first and then remove this logic.


Behavior

Before the change?

  • Previews logic was removed

After the change?

  • Previews logic has been reintroduced.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

@nickfloyd nickfloyd added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 13, 2023
@nickfloyd nickfloyd merged commit 4a8998e into main Jan 13, 2023
@nickfloyd nickfloyd deleted the revert-preview-removal branch January 13, 2023 18:42
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 8.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants