Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new parseSuccessResonseBody option for requests #563

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

wolfy1339
Copy link
Member

Prerequisite to octokit/request.js#602


Behavior

Before the change?

  • The request response data would always be parsed

After the change?

  • Introduces a new option to allow the request response body to not be parsed

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Feature/model/API additions: Type: Feature

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Jul 9, 2023
@Uzlopak
Copy link

Uzlopak commented Jul 9, 2023

nice

@wolfy1339 wolfy1339 merged commit f70144e into main Jul 10, 2023
@wolfy1339 wolfy1339 deleted the new-request-request-option branch July 10, 2023 17:13
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants