Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change matrix.node to matrix.node_version #850

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

wolfy1339
Copy link
Member

All the other Js Octokit repos use node_version, therefore this workflow should be normalized to use the same names

Resolves #ISSUE_NUMBER


Behavior

Before the change?

  • This repo was using node as the matrix name in the test.yml workflow

After the change?

  • Normalize the name to correspond to the other Octokit repos

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Dependencies/code cleanup: Type: Maintenance

All the other Js Octokit repos use `node_version`, therefore this workflow should be normalized to use the same names
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label May 13, 2023
@kfcampbell kfcampbell merged commit c38a34a into main May 15, 2023
@kfcampbell kfcampbell deleted the normalize-workflow branch May 15, 2023 22:01
@github-actions
Copy link
Contributor

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants