-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handles verify error #917
Conversation
🎉 This PR is included in version 9.26.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
we have a problem, the build did not work as expected. Compare https://unpkg.com/browse/@octokit/webhooks@9.26.0/ and https://unpkg.com/browse/@octokit/webhooks@9.26.1/ I feel like we have seen this before. I think @wolfy1339 figured it out in the past? I'm not sure. I know we moved away from pika because of its build problems, but we really need to get this one out correctly |
We also had a patch to fix the I think that is what's needed here |
can you find the patch? 🙏🏼 sorry I've to run in a second and won't be able to help until later today |
I found this PR that replaces pika with the new build setup, but I don't see a pika patch in the previous setup? I also looked into the release build for 9.x and it looks good, as if all folders were created correctly: It also worked as expected locally |
@wolfy1339 Was this it? e178758 |
I tried to just trigger another release and also added an |
I did revert to 9.26.0 for the 9.x release channel
|
No description provided.