Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass through TTransformed to onAny and onError #924

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Nov 18, 2023

See probot/probot#1643

Resolves #ISSUE_NUMBER


Before the change?

  • When users would pass a transform option the type would not be passed down to the onAny and onError functions

After the change?

  • The transform option is passed down

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented, or is being fixed label Nov 18, 2023
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 merged commit 6ead0b7 into main Nov 18, 2023
6 checks passed
@wolfy1339 wolfy1339 deleted the pass-TTransformed-onAny-onError branch November 18, 2023 01:40
Copy link
Contributor

🎉 This PR is included in version 12.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants