-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add additional configuration option #568
feat: add additional configuration option #568
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hety @ganhammar Thanks for the changes here! ❤️ It would be awesome to get some tests in here as well if / when you have time.
Hey @nickfloyd! I have added a new test project for |
Any interest of this PR or should I close it? 😊 |
We definitely have interest in this. Thank you for the efforts. We're just a bit behind on cycling through all of the reviews across Octokit. We'll need to retrigger ci to get things verified, once that's done we should be able to ✅ and merge your changes in. |
Resolves #567
Before the change?
GitHubWebhooksOptions
using a static value, at least through the extension methodAfter the change?
GitHubWebhooksOptions
through anIConfiguration
instancePull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!