Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional configuration option #568

Merged

Conversation

ganhammar
Copy link
Contributor

@ganhammar ganhammar commented Sep 6, 2024

Resolves #567


Before the change?

  • Currently, it's only possible to configure GitHubWebhooksOptions using a static value, at least through the extension method

After the change?

  • With this PR, another configuration option has been added that allows to configure GitHubWebhooksOptions through an IConfiguration instance

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

github-actions bot commented Sep 6, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

nickfloyd
nickfloyd previously approved these changes Sep 17, 2024
Copy link
Collaborator

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hety @ganhammar Thanks for the changes here! ❤️ It would be awesome to get some tests in here as well if / when you have time.

@ganhammar
Copy link
Contributor Author

Hey @nickfloyd!

I have added a new test project for Octokit.Webhooks.AzureFunctions and tests covering the added extension method and the one that already existed. Let me know if any additional changes is needed 🙂

@ganhammar
Copy link
Contributor Author

Any interest of this PR or should I close it? 😊

@nickfloyd
Copy link
Collaborator

nickfloyd commented Oct 8, 2024

Any interest of this PR or should I close it? 😊

We definitely have interest in this. Thank you for the efforts. We're just a bit behind on cycling through all of the reviews across Octokit. We'll need to retrigger ci to get things verified, once that's done we should be able to ✅ and merge your changes in.

@nickfloyd nickfloyd merged commit 9373184 into octokit:main Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: Allow to configure secret using IConfiguration instance
2 participants