[Llama] Add descriptive names for symbolic variables #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Equivalent to the upstream mlc-ai#1684, but for the llama model definitions present in the octoml fork. |
sunggg
approved these changes
Jan 30, 2024
|
LGTM, I merged the other PR before knowing this, would you mind rebase to the latest? |
Because the symbolic variables may appear in many places throughout the resulting module, they should have more descriptive names, which can be understood outside of their original contexts.
Lunderberg
force-pushed
the
llama_symbolic_var_names
branch
from
fda9d2c to
f10881d
Compare
|
Certainly, and rebased! |
Lunderberg
pushed a commit
to Lunderberg/mlc-llm
that referenced
this pull request
Feb 27, 2024
* Update * fix --------- Co-authored-by: tqchen <tqchenml@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the symbolic variables may appear in many places throughout the resulting module, they should have more descriptive names, which can be understood outside of their original contexts.