Remove the TVM submodule #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it should be fine. I plan to remove all the unnecessary folders/files (including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in CI, every time we
git pullthe OLLM repository recursively, we have to checkout a version of TVM (and all it's submodules) twice, once inollm/deps/tvmand the second inollm/deps/mlc-llm/3rdparty/tvm. Since we're not using the latter, I propose removing it here.I assume this should be fine since we aren't using mlc-llm compiled bits, but would be good for someone to confirm.
Also, this time is non-trivial: it takes about a minute each time our github runners need to
actions/checkoutOLLM recursively. And < 10 seconds without recursive checkout.