[Refactor] Clean-up Management of Model/Artifact/Engine Info #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, there are several factors that makes the deployment flow tricky:
num_shards
besides model artifact. This is unnecessary.Changes
To overcome these issues, this PR lands the following changes:
ModelArtifactConfig
while deployment info is managed byMLCServeEngineConfig
.ModelArtifactConfig
andMLCServeEngineConfig
build_config.json
.--num-shards N
should suffice.Todo
mlc_serve
having dependency onmlc_llm
makes the packaging tricky. Better to remove it.cc. @jroesch @elvin-n @masahi