Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inverse_transform): make undummify work when there is the separator in the variable name #111

Merged
merged 3 commits into from
Jan 18, 2024
Merged

fix(inverse_transform): make undummify work when there is the separator in the variable name #111

merged 3 commits into from
Jan 18, 2024

Conversation

jpetot
Copy link
Contributor

@jpetot jpetot commented Jan 18, 2024 •
edited
Loading

  • rename dummmies_prefix_sep into dummies_separator
  • fix undummify to work when the dummies seprator is in the variable name

@jpetot jpetot changed the title fix(inverse_transform): make inverse transform work when there is the separator in the variable name fix(inverse_transform): make undummify work when there is the separator in the variable name Jan 18, 2024
@jpetot jpetot marked this pull request as ready for review January 18, 2024 11:11
tas17
tas17 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@tas17 tas17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

olivierabz
olivierabz approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@olivierabz olivierabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one (something to keep in mind when using split)

tcrasset
tcrasset approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@tcrasset tcrasset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@jpetot jpetot merged commit 08d6b3d into main Jan 18, 2024
2 checks passed
@jpetot jpetot deleted the jp/fix_inverse_transform branch January 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcrasset tcrasset tcrasset approved these changes

@tas17 tas17 tas17 approved these changes

@olivierabz olivierabz olivierabz approved these changes

@mguillaudeux mguillaudeux Awaiting requested review from mguillaudeux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpetot @tcrasset @tas17 @olivierabz