Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get commits from pull request and remove LAST_PULL_REQUEST stop point option #50

Merged
merged 12 commits into from
Nov 16, 2021

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Nov 16, 2021

Summary

Ensure all commits from a pull request are used when compiling release notes.

Contents (#50)

IMPORTANT: There is 1 breaking change.

Enhancements

  • Add quotation marks to default valid commit header endings (commit message checker)

Fixes

  • Get commits from pull request if provided (release notes compiler)

Refactoring

  • BREAKING CHANGE: Remove LAST_PULL_REQUEST stop point option (release notes compiler)

Operations

  • Stop requiring all git history to be fetched in pull request workflow - this speeds up the workflow, especially for larger repositories

@cortadocodes cortadocodes self-assigned this Nov 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #50 (de4af0e) into main (eba3411) will decrease coverage by 0.33%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   97.47%   97.14%   -0.34%     
==========================================
  Files           4        4              
  Lines         277      280       +3     
==========================================
+ Hits          270      272       +2     
- Misses          7        8       +1     
Impacted Files Coverage Δ
conventional_commits/check_commit_message.py 100.00% <ø> (ø)
conventional_commits/compile_release_notes.py 96.37% <89.28%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba3411...de4af0e. Read the comment docs.

@cortadocodes cortadocodes changed the title Get commits from pull request and remove LAST_PULL_REQUEST stop point Get commits from pull request and remove LAST_PULL_REQUEST stop point option Nov 16, 2021
@cortadocodes cortadocodes merged commit 7f05d55 into main Nov 16, 2021
@cortadocodes cortadocodes deleted the fix/get-commits-from-pull-request branch November 16, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing commits from PR history Allow quotation marks at end of commit headers
2 participants