Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uuid to v9.0.1 (fixes module resolution issues with Jest+jsdom) #70

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

haraldreingruber-dedalus
Copy link
Contributor

Hi,

I've updated uuid to v9 in my fork, because I ran into issues when resolving uuid in the jest-environment-jsdom.

This has been improved in v9 (https://github.com/uuidjs/uuid/blob/ca1d39d58a6308d5311bcb356a931aa818ec0ded/CHANGELOG.md#bug-fixes), so I thought it might be a good idea to move this dependency forward?

Also, note that support for Node v10 has been dropped: https://github.com/uuidjs/uuid/blob/ca1d39d58a6308d5311bcb356a931aa818ec0ded/CHANGELOG.md#-breaking-changes

What do you think about upgrading?

Thanks,
Harald

@chris--jones
Copy link

Is there a reason to not use the built-in uuid (other than support for older Node versions)?
https://nodejs.org/api/crypto.html#cryptorandomuuidoptions

@oculus42
Copy link
Owner

Sorry for the long delay in response. with regard to @chris--jones I would like to implement the v9 for users of older Node releases, and then increment the major and make the latest edition use the built-in UUID generation.

@oculus42 oculus42 merged commit f03ca42 into oculus42:develop Apr 29, 2024
1 check passed
@oculus42
Copy link
Owner

As a note, @chris--jones the UUID package does use native crypto.randomUUID when available, but I will eliminate the uuid package dependency in 6.0.0.

@oculus42
Copy link
Owner

oculus42 commented Apr 29, 2024

v5.0.0 has been published with uuid v9.0.1. Thanks @haraldreingruber-dedalus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants