Update to dune 2 #18
Merged
Update to dune 2 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to support OCaml 4.12, and to test projects using dune 2. - Ran `dune upgrade` using dune 2.8.5. - Removed all `(modes byte exe)` lines. - Removed `build` annotation in opam file.
In CI, we don't have the whole machine, so limit to 2 instances and don't fail if we can't get exclusive access to a CPU.
|
To make ocaml-ci pass, I also changed the short test to run with |
This was referenced Jul 6, 2021
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Jul 7, 2021
CHANGES: - update to dune 2 (ocurrent/bun#18, by @talex5 and @edwintorok) - use `-M` for first worker (ocurrent/bun#17, by @edwintorok and @talex5) - move bun to https://github.com/ocurrent/bun (ocurrent/bun#20, by @talex5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support OCaml 4.12, and to test projects using dune 2:
dune upgradeusing dune 2.8.5.(modes byte exe)lines.buildannotation in opam file and updated dependency constraint.Note: I've just noticed there's also #15, which is similar to this. That version looks fine too, except that it needs the
buildannotation removed.