Fix compatibility with spawn v0.12.0 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much! This looks good but I'm going to hold off on merging it until I've pushed some unrelated commits, for ease of cutting a sensible bugfix release compatible with the earlier |
|
ack |
yomimono
added a commit
to yomimono/opam-repository
that referenced
this pull request
May 24, 2019
CHANGES: - use spawn v0.12 API (ocurrent/bun#5, @diml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the type of environments to be abstract in spawn v0.12.0 so that we may optimize their representation in the future. This PR updates the call to
Spawn.spawnfollowing this change.