Use Lwt to manage processes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran `dune upgrade` and deleted `pkg`.
Avoids having to pass `verbosity` flag all over the place, and shows timestamps.
|
Thanks for this! I have no trouble believing that these changes are an improvement. Would you like to be added as an author? It's a pretty substantial rewrite. |
|
OK, added! Does it work for you? |
|
Hmm, bun's Travis CI is failing because |
|
It looks like previously AFL detected a crash but we didn't report it which is definitely wrong 🙄 |
yomimono
added a commit
to yomimono/opam-repository
that referenced
this pull request
May 24, 2019
CHANGES: - use Lwt to manage processes (ocurrent/bun#7, by @talex5) - print crashes when killing a fuzzer in no-kill mode (ocurrent/bun#8, by @NathanReb) - do some CI maintenance (ocurrent/bun#10, by @yomimono)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #6. I also migrated to Dune, switched to
Logsfor logging to simplify the code, and added timestamps. Only lightly tested so far...