Support new ocaml-variants layout #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Looks good to me, once ocaml/opam-repository#17541 and ocurrent/ocaml-version#22 are merged.
|
Pushed to live |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocaml/opam-repository#17541 seeks to solve the combinatorial explosion of
ocaml-variantspackages, with a trial for the 4.12 packages only which affects the generation of the variant packages for tier 1 images (but not by much).All that changes here is that
opam switch createneeds to use--packagesandOcaml_version.Opam.V2now has an extra function which returns the list of additional packages which are required.@AltGr and I are just polishing the opam-repository PR - it should be the case that the 4.12-afl image, for example, will use
ocaml-variants.4.12.0+trunkandocaml-options-only-afl, the-only-versions of packages prevent dependencies from changing the underlying compiler.