Raise and reraise exceptions with Stdlib rather than Lwt #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
lwt-exceptions
branch
3 times, most recently
from
94d8372
to
ae18e09
Compare
MisterDA
force-pushed
the
lwt-exceptions
branch
from
ae18e09
to
2639416
Compare
MisterDA
force-pushed
the
lwt-exceptions
branch
3 times, most recently
from
1109de1
to
771a198
Compare
Lwt's documentation reads: > In most cases, it is better to use `failwith s` from the standard > library. and > Whenever possible, it is recommended to use `raise exn` instead, as > raise captures a backtrace, while `Lwt.fail` does not. If you call > `raise exn` in a callback that is expected by Lwt to return a > promise, Lwt will automatically wrap `exn` in a rejected promise, > but the backtrace will have been recorded by the OCaml runtime. > > For example, `bind`'s second argument is a callback which returns a > promise. And so it is recommended to use `raise` in the body of that > callback. > > Use `Lwt.fail` only when you specifically want to create a rejected > promise, to pass to another function, or store in a data structure. Prefer to capture backtraces to improve debugability.
MisterDA
force-pushed
the
lwt-exceptions
branch
from
771a198
to
1ab3ba6
Compare
MisterDA
commented
Sep 10, 2024
talex5
approved these changes
Sep 10, 2024
|
@shonfeder I can't merge this because of the new rules preventing merges if the CI doesn't pass. |
The system works! :D Tho unfortunately the CI failures here are just #186. |
|
Thanks again for this fix :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lwt's documentation reads:
and
Prefer to capture backtraces to improve debugability.
See also ocsigen/lwt#1008.