Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable warnings-as-errors on old OCaml versions #265

Conversation

kit-ty-kate
Copy link
Contributor

Older versions of the compiler often trigger warnings that we might want to get rid of. For instance unsupported (at the time) documentation comments or something of the sort. There is easy way to deal with those for users of ocaml-ci so my suggestion would be to disable warnings-as-errors for all version of the compiler but the latest.

Ideally it would be best to detect the latest available version for the current packages but I couldn't get it to work in a reasonable amount of time so that'd be for another time, the regular extra checks such as flambda, and the diverse other distributions also suffer from this anyway.

@kit-ty-kate
Copy link
Contributor Author

@talex5
Copy link
Contributor

talex5 commented Oct 26, 2020

I think it would be better for projects where this is a problem to disable the warning themselves in their dune files. We're already running odoc using the latest version of the compiler, so I guess that would find important doc errors, even when it's disabled in dune.

@kit-ty-kate
Copy link
Contributor Author

The documentation issues are just an example, there can be other warnings that are triggered by older compilers but not on new one and dune does not have a way to give different flags to the compilers according to its version easily. I guess what I want is ocaml/dune#90

Currently it can be done with a custom rule and (:include ...) directive but it's quite painful.
Fair enough, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants