-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public Ocluster_worker library #151
Conversation
e6f4d76
to
f5884b0
Compare
I've rebased the PR as I respent a few hours trying not to remove the
(I don't know how to keep the |
65a9555
to
caee589
Compare
Circling back on this after a long while, as I'm going to cut a release of ocluster soon. |
…uster (0.2.1) CHANGES: - Expose the ocluster-worker library in the ocluster-worker package (@MisterDA @art-w, ocurrent/ocluster#219 ocurrent/ocluster#217 ocurrent/ocluster#151, reviewed by @tmcgilchrist) - Remove corrupted repositories from the cache (@kit-ty-kate ocurrent/ocluster#216, reviewed by @talex5) - Allow workers to report additional prometheus metrics (@patricoferris ocurrent/ocluster#210, reviewed by @tmcgilchrist, @MisterDA) - Smother Cap'n Proto and TLS debug logs (@MisterDA ocurrent/ocluster#213, reviewed by @talex5) - Added command line option to set obuilder health check period (@mtelvers ocurrent/ocluster#214, reviewed by @tmcgilchrist) - Conditionally compile macos user_temp fetcher (@tmcgilchrist ocurrent/ocluster#209, reviewed by @MisterDA, @mtelvers) - Make rsync-mode mandatory when using rsync store (@tmcgilchrist ocurrent/ocluster#202, reviewed by @MisterDA) - Windows service bugfixes (@MisterDA ocurrent/ocluster#200, reviewed by @tmcgilchrist) - Fix build and opam metadata (@MisterDA @tmcgilchrist ocurrent/ocluster#199 ocurrent/ocluster#203)
…uster (0.2.1) CHANGES: - Expose the ocluster-worker library in the ocluster-worker package (@MisterDA @art-w, ocurrent/ocluster#219 ocurrent/ocluster#217 ocurrent/ocluster#151, reviewed by @tmcgilchrist) - Remove corrupted repositories from the cache (@kit-ty-kate ocurrent/ocluster#216, reviewed by @talex5) - Allow workers to report additional prometheus metrics (@patricoferris ocurrent/ocluster#210, reviewed by @tmcgilchrist, @MisterDA) - Smother Cap'n Proto and TLS debug logs (@MisterDA ocurrent/ocluster#213, reviewed by @talex5) - Added command line option to set obuilder health check period (@mtelvers ocurrent/ocluster#214, reviewed by @tmcgilchrist) - Conditionally compile macos user_temp fetcher (@tmcgilchrist ocurrent/ocluster#209, reviewed by @MisterDA, @mtelvers) - Make rsync-mode mandatory when using rsync store (@tmcgilchrist ocurrent/ocluster#202, reviewed by @MisterDA) - Windows service bugfixes (@MisterDA ocurrent/ocluster#200, reviewed by @tmcgilchrist) - Fix build and opam metadata (@MisterDA @tmcgilchrist ocurrent/ocluster#199 ocurrent/ocluster#203)
For current-bench and sandmark, we need to experiment with a different kind of worker that build images, and then run them with custom settings to ensure that the benchmarks are stable. This PR exposes the internal library
Ocluster_worker
to help us extend the existing build behaviour.However there is an issue with the
obuilder
git submodule that causes linker errors when trying to use the resultingocluster-worker
library: It gets compiled with the pinned obuilder, but it still requires a dependency on the publicly released obuilder (causing a conflict, see ocaml/dune#3911). That's why the second commit removes the submodule and replaces it with an opam pin. Is there an alternative solution to this issue that you would prefer?