Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

Check that default, example tags have been removed #31

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

punchagan
Copy link
Collaborator

Lot of repositories in the opam repository have "topics" as their first tag, possibly due to an oversight from the maintainers. This commit adds an explicit check to warn against that.

Closes #26.

@punchagan punchagan requested a review from shonfeder August 28, 2024 12:04
lib/lint.ml Outdated Show resolved Hide resolved
lib/lint_error.ml Outdated Show resolved Hide resolved
@shonfeder
Copy link
Collaborator

It's awesome that you have driven these improvements down to the root causes by improving the dune init template, btw :)

@punchagan punchagan force-pushed the lint-tags branch 3 times, most recently from 93212ae to 404804e Compare August 29, 2024 05:45
@punchagan punchagan requested a review from shonfeder August 29, 2024 05:47
@punchagan punchagan changed the title Check that "topics" is not the first tag Check that default, example tags have been removed Aug 29, 2024
Copy link
Collaborator

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Lot of repositories in the opam repository have "topics" as their first
tag, possibly due to an oversight from the maintainers. This commit adds
an explicit check to warn against leaving the default, example tags in.

Closes #26.
@punchagan punchagan enabled auto-merge August 30, 2024 04:19
@punchagan punchagan added this pull request to the merge queue Aug 30, 2024
Merged via the queue into ocurrent:main with commit ba2e964 Aug 30, 2024
1 check passed
@punchagan punchagan deleted the lint-tags branch August 30, 2024 04:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint: Check topics is not the first tag in the opam file
2 participants