introduce empty data state incase user deselects all options

odaridavid · Mar 11, 2024 · 8283909 · 8283909
1 parent d04f433
commit 8283909
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/src/main/java/com/github/odaridavid/weatherapp/core/model/ExcludedData.kt b/app/src/main/java/com/github/odaridavid/weatherapp/core/model/ExcludedData.kt
@@ -5,4 +5,5 @@ enum class ExcludedData(val value:String){
     DAILY("daily"),
     MINUTELY("minutely"),
     ALERTS("alerts"),
+    NONE(""),
 }
diff --git a/app/src/main/java/com/github/odaridavid/weatherapp/ui/settings/SettingsViewModel.kt b/app/src/main/java/com/github/odaridavid/weatherapp/ui/settings/SettingsViewModel.kt
@@ -2,6 +2,7 @@ package com.github.odaridavid.weatherapp.ui.settings
 
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
+import com.github.odaridavid.weatherapp.core.api.Logger
 import com.github.odaridavid.weatherapp.core.api.SettingsRepository
 import com.github.odaridavid.weatherapp.core.model.ExcludedData
 import dagger.hilt.android.lifecycle.HiltViewModel
@@ -14,7 +15,8 @@ import javax.inject.Inject
 
 @HiltViewModel
 class SettingsViewModel @Inject constructor(
-    private val settingsRepository: SettingsRepository
+    private val settingsRepository: SettingsRepository,
+    private val logger: Logger,
 ) : ViewModel() {
 
     private val _state = MutableStateFlow(SettingsScreenViewState())
@@ -104,7 +106,10 @@ class SettingsViewModel @Inject constructor(
                 ExcludedData.DAILY.value -> ExcludedData.DAILY
                 ExcludedData.MINUTELY.value -> ExcludedData.MINUTELY
                 ExcludedData.ALERTS.value -> ExcludedData.ALERTS
-                else -> throw IllegalArgumentException("Invalid excluded data")
+                else ->{
+                    logger.logException(IllegalArgumentException("Invalid excluded data"))
+                    ExcludedData.NONE
+                }
             }
         }
     }