Automated dependency upgrades #153
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
✅ Deploy Preview for oddcontrast ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jgerigmeyer
force-pushed
the
auto-dependency-upgrades
branch
from
59815ef
to
dcafa35
Compare
jgerigmeyer
force-pushed
the
auto-dependency-upgrades
branch
from
dcafa35
to
95509ec
Compare
jgerigmeyer
force-pushed
the
auto-dependency-upgrades
branch
from
95509ec
to
6137620
Compare
jgerigmeyer
force-pushed
the
auto-dependency-upgrades
branch
from
6137620
to
2e5ecc1
Compare
jgerigmeyer
force-pushed
the
auto-dependency-upgrades
branch
2 times, most recently
from
634d63f
to
0405c21
Compare
jgerigmeyer
force-pushed
the
auto-dependency-upgrades
branch
2 times, most recently
from
03bd1b4
to
cbb11ad
Compare
jgerigmeyer
force-pushed
the
auto-dependency-upgrades
branch
from
cbb11ad
to
5cab0d7
Compare
jgerigmeyer
force-pushed
the
auto-dependency-upgrades
branch
from
5cab0d7
to
e594af0
Compare
| @@ -11,6 +11,7 @@ export default defineConfig({ | |||
| preprocessorOptions: { | |||
| scss: { | |||
| includePaths: [path.resolve('./src/sass/')], | |||
| pkgImporter: new NodePackageImporter('.'), | |||
There was a problem hiding this comment.
For some reason, without this '.' I was getting the ol' error again:
failed to load config from /Users/jonny/Sites/oddcontrast/vite.config.ts
error during build:
The Node package importer cannot determine an entry point because `require.main.filename` is not defined. Please provide an `entryPointDirectory` to the `NodePackageImporter`.
🤷
There was a problem hiding this comment.
Hmm- my read of this is that it only matches if there are 2 arguments in the value of argv. The command that's getting run is yarn svelte:serve, which is vite dev --host 0.0.0.0, so it has 5 arguments.
Replacing svelte:serve with vite makes this work. If that sounds correct, I'll open a bug for Natalie to look at.
There was a problem hiding this comment.
Interesting, yeah that makes sense 👍
|
@jamesnw Package imports! Color.js v0.5! Yarn v4! All the shiny things! (Except sass-embedded, cause Vite doesn't support it yet.) |
| @@ -11,6 +11,7 @@ export default defineConfig({ | |||
| preprocessorOptions: { | |||
| scss: { | |||
| includePaths: [path.resolve('./src/sass/')], | |||
| pkgImporter: new NodePackageImporter('.'), | |||
There was a problem hiding this comment.
Hmm- my read of this is that it only matches if there are 2 arguments in the value of argv. The command that's getting run is yarn svelte:serve, which is vite dev --host 0.0.0.0, so it has 5 arguments.
Replacing svelte:serve with vite makes this work. If that sounds correct, I'll open a bug for Natalie to look at.
Full log: https://github.com/oddbird/oddcontrast/actions/runs/7245198850