Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests. #3

Merged
merged 7 commits into from
Mar 31, 2022
Merged

Add tests. #3

merged 7 commits into from
Mar 31, 2022

Conversation

jgerigmeyer
Copy link
Member

Coverage is not being enforced, because there seems to be an outstanding bug with Svelte component coverage: svelteness/svelte-jester#43

@jgerigmeyer jgerigmeyer requested a review from jerivas March 30, 2022 16:31
@jgerigmeyer jgerigmeyer marked this pull request as draft March 30, 2022 16:57
@jgerigmeyer jgerigmeyer requested a review from mirisuzanne March 30, 2022 18:56
@jgerigmeyer jgerigmeyer marked this pull request as ready for review March 30, 2022 18:56
@jgerigmeyer
Copy link
Member Author

Copy link
Member Author

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerivas Not urgent, but I'd appreciate your review here when you have a few minutes.

.github/workflows/test.yml Show resolved Hide resolved
test/tsconfig.json Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
* sass:
  adjust global style approach; prevents duplicate styles in dev
  remove placeholder content in sliders
  clean up icons
  list alignment move to global
  not sure we will have hr
  remove unused padding
  can add components back if needed, or use scoped instead
  not convinced we need remedy on this project
  simplify gap
  alignment/spacing clean up
  edit default colors
  adjust layout so header stetches to full height on large
  clean up swatch css
  add links to oddbird sites for now
Copy link
Member

@jerivas jerivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants