Add whatwg-fetch polyfill. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgerigmeyer
commented
Nov 1, 2019
| import { getAuthToken, getEnableConfig, TrelloPromise } from './store'; | ||
|
|
||
| export const API_BASE_URL = 'https://api.harvestapp.com/api/v2/'; | ||
| export const API_BASE_URL = 'https://api.harvestapp.com/v2/'; |
There was a problem hiding this comment.
@carljm I guess apparently both of these work? This now matches the docs, as far as I can tell.
There was a problem hiding this comment.
(I did functionally test this -- it works the same as far as I can tell.)
carljm
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cute animal pic
Because everyone likes pictures of animals.
Description
The commit messages say what you did; this should explain why and how.
Because Babel does not automatically polyfill the
fetchAPI for older browsers (see https://github.com/zloirock/core-js#missing-polyfills and zloirock/core-js#25).Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally.
I guess fire up your old IE11 browser to test functionally? I didn't bother.
Reviewer tasks: