SVG instead of Gradient-Background #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing the Gradient Background with a Generated SVG results in a more precise preview-grid. This ist a Modified version of Dennis de Goedes method for dynamic SVG Backgrounds http://blog.trifork.com/2014/05/14/advanced-theming-dynamic-svg-backgrounds-with-sass-the-right-way/ Utilitzing a string-Replace methos by by Hugo Giraudel I encode the raw SVG after generating it. This ensure compatibility with Firefox and IE. Signed-off-by: Michael Gehrmann <m@g12n.de>
Signed-off-by: Michael Gehrmann <m@g12n.de>
Signed-off-by: Michael Gehrmann <m@g12n.de>
|
I removed the duplicate str-replace and a stupid bug in the background-grid function. |
This was referenced Jun 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the Gradient Background with a Generated SVG results in a more precise preview-grid.
This ist a Modified version of Dennis de Goedes method for dynamic SVG Backgrounds:
http://blog.trifork.com/2014/05/14/advanced-theming-dynamic-svg-backgrounds-with-sass-the-right-way/
Utilitzing a string-Replace methos by by Hugo Giraudel I encode the raw SVG after generating it. This ensure compatibility with Firefox and IE.
This is a quiet massive change. New Tests have to be written.
Signed-off-by: Michael Gehrmann m@g12n.de