Css view transitions 2 #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesnw
approved these changes
Oct 4, 2024
Collaborator
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
A few nits, but I think this is ready to upstream!
| @@ -0,0 +1,9 @@ | |||
| name: Cross-document view transitions | |||
| description: The `@view-transition` CSS rule sets whether a document opts-in to transitions from one document to another. Both the old and new document must opt-in for a transition to be triggered. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| description: The `@view-transition` CSS rule sets whether a document opts-in to transitions from one document to another. Both the old and new document must opt-in for a transition to be triggered. | |
| description: The `@view-transition` CSS rule sets whether a document opts-in to transitions between documents in a multi-page application. Both the old and new document must opt-in for a transition to be triggered. |
Getting MPA in there for searchability.
groups/transitions.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| # Features for managing transitions of properties, elements, and documents | |||
| name: Transitions | |||
Collaborator
There was a problem hiding this comment.
I think this should be View Transitions with id view-transitions - see web-platform-dx#1771 (comment) for the rationale.
| # edge: "125" | ||
| - api.ViewTransition.types | ||
| - api.ViewTransitionTypeSet | ||
| - css.selectors.active-view-transition-type |
Collaborator
There was a problem hiding this comment.
There's a chance that someone in review (or down the road) might want to refer to active-view-transition and active-view-transition-type separately, but I think keep them combined until someone suggests otherwise. It could really go either way.
features/active-view-transition.yml
Outdated
| name: Active view transition | ||
| description: The `::active-view-transition` CSS pseudo-class matches the root element when a view transition is active. The `::active-view-transition-type()` CSS pseudo-class matches only when the active view transition was started with the specified type. | ||
| spec: https://drafts.csswg.org/css-view-transitions-2/#the-active-view-transition-pseudo | ||
| group: transitions |
Collaborator
There was a problem hiding this comment.
Suggested change
| group: transitions | |
| group: | |
| - transitions | |
| - selectors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.