Fix when link_to_remove contain html #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Belibaste. I fixed this is in #9 . The improvement is available in v1.0.4. Do not change original author references next time ;) |
|
Nice ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This is a small fix for the
removeFieldsHandlerwhen thelink_to_remove_associationis not only a string, but contain some HTML elements, like the close button from Bootstrap.As I think this repo is the one people find when they look for a replacement of Cocoon JS (as I did), it would help some of us.
PS @kollegorna : I am not used to contribute, so if you have something to tell me about this, or any advice or comment on this PR, you are very welcome :-)