feat: allow disabling player heads in menus for slow servers (closes #…

…105)
oddlama · Feb 18, 2022 · 3af7ced · 3af7ced
1 parent 3dba537
commit 3af7ced
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/vane-core/src/main/java/org/oddlama/vane/core/Core.java b/vane-core/src/main/java/org/oddlama/vane/core/Core.java
@@ -55,6 +55,9 @@ public static Core instance() {
 	private CustomModelDataRegistry model_data_registry;
 	private CustomItemRegistry item_registry;
 
+	@ConfigBoolean(def = true, desc = "Allow loading of player heads in relevant menus. Disabling this will show all player heads using the Steve skin, which may perform better on low-performance servers and clients.")
+	public boolean config_player_heads_in_menus;
+
 	@LangMessage
 	public TranslatedMessage lang_command_not_a_player;
 

diff --git a/vane-core/src/main/java/org/oddlama/vane/util/ItemUtil.java b/vane-core/src/main/java/org/oddlama/vane/util/ItemUtil.java
@@ -252,11 +252,11 @@ public int compare(final ItemStack a, final ItemStack b) {
 		}
 	}
 
-	public static ItemStack skull_for_player(final OfflinePlayer player) {
+	public static ItemStack skull_for_player(final OfflinePlayer player, final boolean is_for_menu) {
 		final var item = new ItemStack(Material.PLAYER_HEAD);
-		final var meta = (SkullMeta) item.getItemMeta();
-		meta.setOwningPlayer(player);
-		item.setItemMeta(meta);
+		if (!is_for_menu || Core.instance().config_player_heads_in_menus) {
+			item.editMeta(SkullMeta.class, meta -> meta.setOwningPlayer(player));
+		}
 		return item;
 	}
 

diff --git a/vane-regions/src/main/java/org/oddlama/vane/regions/menu/RoleMenu.java b/vane-regions/src/main/java/org/oddlama/vane/regions/menu/RoleMenu.java
@@ -287,7 +287,7 @@ private MenuWidget menu_item_assign_player(final RegionGroup group, final Role r
 						lang_select_assign_player_title.str(),
 						lang_filter_players_title.str(),
 						all_players,
-						p -> item_select_player.alternative(ItemUtil.skull_for_player(p), "§a§l" + p.getName()),
+						p -> item_select_player.alternative(ItemUtil.skull_for_player(p, true), "§a§l" + p.getName()),
 						filter,
 						(player2, m, p) -> {
 							all_players.remove(p);
@@ -334,7 +334,7 @@ private MenuWidget menu_item_remove_player(final RegionGroup group, final Role r
 						lang_select_remove_player_title.str(),
 						lang_filter_players_title.str(),
 						all_players,
-						p -> item_select_player.alternative(ItemUtil.skull_for_player(p), "§a§l" + p.getName()),
+						p -> item_select_player.alternative(ItemUtil.skull_for_player(p, true), "§a§l" + p.getName()),
 						filter,
 						(player2, m, p) -> {
 							all_players.remove(p);