Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push inside non-existent directory doesn't seem to work #933

Closed
alexiou1977 opened this issue Jul 3, 2017 · 12 comments · Fixed by #941
Closed

push inside non-existent directory doesn't seem to work #933

alexiou1977 opened this issue Jul 3, 2017 · 12 comments · Fixed by #941
Milestone
v0.4.0

Comments

@alexiou1977
Copy link

Hi,

I have done some changes to a folder of a locally-mounted remote path but these changes are not pushed to the remote directory. I am just getting the message that everything is up-to-date. What is happening?

Thanks
@CountryBumkin
Copy link

Try the -ignore-checksum option on Push and Pull commands, more details here https://github.com/odeke-em/drive#verifying-checksums

Regards CB

@alexiou1977
Copy link
Author

Not working...

~/go/bin/drive push -ignore-checksum VCFs/

@CountryBumkin
Copy link

The logic is a bit perverse, try something like ....

~/go/bin/drive push -ignore-checksum=false VCFs/

@alexiou1977
Copy link
Author

Still doesn't work! I don't understand what is happening. It used to work very smoothly up to 2 days ago.

Should I better reinstall el drive?

Thanks CB for your suggestions.

@CountryBumkin
Copy link

If the software was working and now fails is a different context. To ensure repeatable testing be sure to execute the drive commands from a command prompt in an interactive terminal window, not in a script file with re-directed output and errors to a log file.

If you are using Linux check the exit status after the drive command. eg
$ drive push -ignore ....
$ echo $?
0 ! this 0 indicates the previous command was correct, numbers suggest various errors.

regards CB

@alexiou1977
Copy link
Author

Yes. I am running the command always in the terminal. One interesting thing is that when I want to see the contents of the remote directory it's telling me that the specified path cannot be found remotely.

~/googleDrive/Local_Work$ pwd
/home/kalexiou/googleDrive/Local_Work

~/googleDrive/Local_Work$ /home/kalexiou/go/bin/drive ls
"/googleDrive/Local_Work" cannot be found remotely

@odeke-em odeke-em changed the title Push function doesn't seem to work push inside non-existent directory doesn't seem to work Jul 7, 2017
@odeke-em
Copy link
Owner

odeke-em commented Jul 7, 2017

Hello @alexiou1977, thank you for the issue and welcome to drive!

Let me try to reproduce this and investigate then fix if necessary.

@alexiou1977
Copy link
Author

Hi odeke-em,

Any news about my issue?

Regards,
Kostas

@odeke-em
Copy link
Owner

Hello @alexiou1977 thanks for the reminder. My apologies for the late reply, I've been travelling around and also pushing out work related code. However, I was able to reproduce this and I think I have a hunch on what is going wrong. I'll try to work on this in the next 9 hours or better over the weekend.

@odeke-em odeke-em added this to the v0.4.0 milestone Jul 20, 2017
odeke-em added a commit that referenced this issue Jul 24, 2017
@odeke-em
changes: properly send back nil if no file is found

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
5040492 
Ensure that nil is properly sent back after remote
change/file resolution. This regression was caused
by forgetting to send back that nil.
The consequence of the bug was that trying to push
from non-existent folders would erraneously give
back
```shell
Resolving...
Everything is up-to-date.
```

since the remotesChan channel would get closed
after resolution without sending notifying
whoever was resolving that the file or parent didn't
exist remotely.

Fixes #933
odeke-em added a commit that referenced this issue Jul 24, 2017
@odeke-em
changes: properly send back nil if no file is found
08ef171 
Ensure that nil is properly sent back after remote
change/file resolution. This regression was caused
by forgetting to send back that nil.

This regression was caused by PR
#741.

The consequence of the bug was that trying to push
from non-existent folders would erraneously give
back
```shell
Resolving...
Everything is up-to-date.
```

since the remotesChan channel would get closed
after resolution without sending notifying
whoever was resolving that the file or parent didn't
exist remotely.

Fixes #933
@odeke-em odeke-em mentioned this issue Jul 24, 2017
Merged
@odeke-em
Copy link
Owner

@alexiou1977 thank you for the patience and for the advocacy to fix this issue. As promised, I've fixed it with PR #941. Please get the latest by

$ go get -u -v github.com/odeke-em/drive/drive-gen && drive-gen

Please reopen if symptoms persist!

@alexiou1977
Copy link
Author

alexiou1977 commented Jul 24, 2017 via email

@odeke-em
Copy link
Owner

🍻 anytime @alexiou1977, hope that solved your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

changes: properly send back nil if no file is found odeke-em/drive
3 participants
@odeke-em @CountryBumkin @alexiou1977