os.path.join() is used for building urls

[Marm0t]

Hello.

As it written in title of this issue os.path.join() is used in someplaces for building urls.
For example in oauth.py:

class OAuth(Namespace):
 [...]
    request_token_url = os.path.join(
        BASE_URL, 'api/auth/v1/oauth/token/request')
    authorize_url = os.path.join(BASE_URL, 'services/api/auth')
    access_token_url = os.path.join(BASE_URL, 'api/auth/v1/oauth/token/access')
 [...]

normally it works fine but for urls os.path.join is not the best either since on Windows systems os.path.join will join using backslash \ which won't be a valid url. As consequence on windows we get exception like this:
Unable to find the server at www.odesk.com\api

Isn't it better to use urlparse.urljoin (and urllib.parse.urljoin for python 3) for this?
Otherwise it should be written somewhere in documentation that Windows is not supported.

Best regards.

[kipanshi]

Actually the use of os.path.join was initially incorrect, as the URI is not the posix path, and
it should be replaced everywhere to

'/'.join(BASE_URL, '/api')

etc.

as the URI always uses slash.
This will be fixed in the next release.