feat: don't make collectors group not ready once set as ready (#1166)

autoscaler/controllers/datacollection/root.go

@@ -2,7 +2,6 @@ package datacollection
 
 import (
 	"context"
-	"fmt"
 
 	odigosv1 "github.com/keyval-dev/odigos/api/odigos/v1alpha1"
 	appsv1 "k8s.io/api/apps/v1"
@@ -72,12 +71,15 @@ func syncDataCollection(instApps *odigosv1.InstrumentedApplicationList, dests *o
 		return err
 	}
 
-	if err := c.Status().Patch(ctx, dataCollection, client.RawPatch(
-		types.MergePatchType,
-		[]byte(fmt.Sprintf(`{"status": { "ready": %t }}`, calcDataCollectionReadyStatus(ds))),
-	)); err != nil {
-		logger.Error(err, "Failed to update data collection status")
-		return err
+	isNowReady := calcDataCollectionReadyStatus(ds)
+	if !dataCollection.Status.Ready && isNowReady {
+		if err := c.Status().Patch(ctx, dataCollection, client.RawPatch(
+			types.MergePatchType,
+			[]byte(`{"status": { "ready": true }}`),
+		)); err != nil {
+			logger.Error(err, "Failed to update data collection status")
+			return err
+		}
 	}
 
 	return nil

autoscaler/controllers/gateway/root.go

@@ -2,7 +2,6 @@ package gateway
 
 import (
 	"context"
-	"fmt"
 
 	odigosv1 "github.com/keyval-dev/odigos/api/odigos/v1alpha1"
 	"github.com/keyval-dev/odigos/common/consts"
@@ -93,8 +92,16 @@ func syncGateway(dests *odigosv1.DestinationList, processors *odigosv1.Processor
 		return err
 	}
 
-	return c.Status().Patch(ctx, gateway, client.RawPatch(
-		types.MergePatchType,
-		[]byte(fmt.Sprintf(`{"status": { "ready": %t }}`, dep.Status.ReadyReplicas > 0)),
-	))
+	isReady := dep.Status.ReadyReplicas > 0
+	if !gateway.Status.Ready && isReady {
+		err := c.Status().Patch(ctx, gateway, client.RawPatch(
+			types.MergePatchType,
+			[]byte(`{"status": { "ready": true }}`),
+		))
+		if err != nil {
+			return err
+		}
+	}
+
+	return nil
 }