Skip to content

Commit

Permalink
fix: do not return err on reconcile when its not retryable (#1529)
Browse files Browse the repository at this point in the history
When instrumentor sees a runtime version it does not support, it should
record this info into the status, and return `nil` from the reconcile
since this issue is not an error we can retry
  • Loading branch information
blumamir authored Sep 20, 2024
1 parent fda3173 commit 220abb3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion instrumentor/controllers/instrumentationdevice/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ func reconcileSingleWorkload(ctx context.Context, kubeClient client.Client, inst
} else {
conditions.UpdateStatusConditions(ctx, kubeClient, instrumentedApplication, &instrumentedApplication.Status.Conditions, metav1.ConditionFalse, appliedInstrumentationDeviceType, string(ApplyInstrumentationDeviceReasonErrRemoving), errRemove.Error())
}
return err
return nil
}

err = addInstrumentationDeviceToWorkload(ctx, kubeClient, instrumentedApplication)
Expand Down

0 comments on commit 220abb3

Please sign in to comment.