Skip to content

Commit

Permalink
Change memory limits of UI/Instrumentor/Scheduler/Autoscaler (#1569)
Browse files Browse the repository at this point in the history
This pull request includes several changes to increase the memory limits
for various deployments in both the Go code and Helm templates. The most
important changes are grouped by their themes: Go code adjustments and
Helm template updates.

### Go Code Adjustments:

*
[`cli/cmd/resources/autoscaler.go`](diffhunk://#diff-7bae822a24a3402d4829c0f22fb8751207963f2ec6f1acfb3909dfb24e946ad6L470-R470):
Increased memory limit from 128Mi to 512Mi in the
`NewAutoscalerDeployment` function.
*
[`cli/cmd/resources/instrumentor.go`](diffhunk://#diff-811884a2ceb6f5d0f13a9a6f4273218bf54fdf7132b69291b9ba648e4242fe6fL504-R504):
Increased memory limit from 128Mi to 512Mi in the
`NewInstrumentorDeployment` function.
*
[`cli/cmd/resources/scheduler.go`](diffhunk://#diff-bdfed18f0b44f694d550d49331398f7131ad4ff76278ef68e0c772981e90d1e2L262-R262):
Increased memory limit from 128Mi to 512Mi in the
`NewSchedulerDeployment` function.
*
[`cli/cmd/resources/ui.go`](diffhunk://#diff-c286e10d34710a80a59127b2b7951e8a33d9b9554e47d2f2b827fd690f2e53abL97-R97):
Increased memory limit from 128Mi to 512Mi in the `NewUIDeployment`
function.

### Helm Template Updates:

*
[`helm/odigos/templates/autoscaler/deployment.yaml`](diffhunk://#diff-0716b0814249b7f1dbfb2a36387f298b24f56d6e40876833d3e4f7adf81a3760L58-R58):
Increased memory limit from 128Mi to 512Mi.
*
[`helm/odigos/templates/instrumentor/deployment.yaml`](diffhunk://#diff-d67f2bcf36e3db81f9797f03be8c6cc9377374f27fdfd38a2b4896ab0b2c9984L61-R61):
Increased memory limit from 128Mi to 512Mi.
*
[`helm/odigos/templates/scheduler/deployment.yaml`](diffhunk://#diff-6a89a4e953dbd0d108bcaa86ce93fd2a25149eaccf3df79bc964d7de486814c3L53-R53):
Increased memory limit from 128Mi to 512Mi.
*
[`helm/odigos/templates/ui/deployment.yaml`](diffhunk://#diff-e029aabc8f82a9d10fd5dd6354d0f8b756c0d0d536509ddd441e9dc641cb27caL41-R41):
Increased memory limit from 128Mi to 512Mi.
  • Loading branch information
edeNFed authored Oct 7, 2024
1 parent 6fa5a14 commit 5c72fb0
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion cli/cmd/resources/autoscaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ func NewAutoscalerDeployment(ns string, version string, imagePrefix string, imag
Resources: corev1.ResourceRequirements{
Limits: corev1.ResourceList{
"cpu": resource.MustParse("500m"),
"memory": *resource.NewQuantity(134217728, resource.BinarySI),
"memory": *resource.NewQuantity(536870912, resource.BinarySI),
},
Requests: corev1.ResourceList{
"cpu": resource.MustParse("10m"),
Expand Down
2 changes: 1 addition & 1 deletion cli/cmd/resources/instrumentor.go
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ func NewInstrumentorDeployment(ns string, version string, telemetryEnabled bool,
Resources: corev1.ResourceRequirements{
Limits: corev1.ResourceList{
"cpu": resource.MustParse("500m"),
"memory": *resource.NewQuantity(134217728, resource.BinarySI),
"memory": *resource.NewQuantity(536870912, resource.BinarySI),
},
Requests: corev1.ResourceList{
"cpu": resource.MustParse("10m"),
Expand Down
2 changes: 1 addition & 1 deletion cli/cmd/resources/scheduler.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ func NewSchedulerDeployment(ns string, version string, imagePrefix string) *apps
Resources: corev1.ResourceRequirements{
Limits: corev1.ResourceList{
"cpu": resource.MustParse("500m"),
"memory": *resource.NewQuantity(134217728, resource.BinarySI),
"memory": *resource.NewQuantity(536870912, resource.BinarySI),
},
Requests: corev1.ResourceList{
"cpu": resource.MustParse("10m"),
Expand Down
2 changes: 1 addition & 1 deletion cli/cmd/resources/ui.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func NewUIDeployment(ns string, version string, imagePrefix string) *appsv1.Depl
Resources: corev1.ResourceRequirements{
Limits: corev1.ResourceList{
"cpu": resource.MustParse("500m"),
"memory": *resource.NewQuantity(134217728, resource.BinarySI),
"memory": *resource.NewQuantity(536870912, resource.BinarySI),
},
Requests: corev1.ResourceList{
"cpu": resource.MustParse("10m"),
Expand Down
2 changes: 1 addition & 1 deletion helm/odigos/templates/autoscaler/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
resources:
limits:
cpu: 500m
memory: 128Mi
memory: 512Mi
requests:
cpu: 10m
memory: 64Mi
Expand Down
2 changes: 1 addition & 1 deletion helm/odigos/templates/instrumentor/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ spec:
resources:
limits:
cpu: 500m
memory: 128Mi
memory: 512Mi
requests:
cpu: 10m
memory: 64Mi
Expand Down
2 changes: 1 addition & 1 deletion helm/odigos/templates/scheduler/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ spec:
resources:
limits:
cpu: 500m
memory: 128Mi
memory: 512Mi
requests:
cpu: 10m
memory: 64Mi
Expand Down
2 changes: 1 addition & 1 deletion helm/odigos/templates/ui/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
resources:
limits:
cpu: 500m
memory: 128Mi
memory: 512Mi
requests:
cpu: 10m
memory: 64Mi
Expand Down

0 comments on commit 5c72fb0

Please sign in to comment.