fix: handle unknown and ignored languages in supported check (#1516)

instrumentor/controllers/utils/versionsupport/ignored_support.go

@@ -0,0 +1,15 @@
+package versionsupport
+
+import "github.com/hashicorp/go-version"
+
+type IgnoredVersionCheck struct{}
+
+func (g IgnoredVersionCheck) IsVersionSupported(version *version.Version) bool {
+	// ignored containers are anyhow not used for device injection.
+	// we will return true here so not to fail all containers due to this check.
+	return true
+}
+
+func (g IgnoredVersionCheck) GetSupportedVersion() string {
+	return ""
+}

instrumentor/controllers/utils/versionsupport/language_version_support.go

@@ -3,6 +3,7 @@ package versionsupport
 import (
 	"context"
 	"fmt"
+
 	"github.com/hashicorp/go-version"
 	"github.com/odigos-io/odigos/api/odigos/v1alpha1"
 	"github.com/odigos-io/odigos/common"
@@ -69,6 +70,10 @@ func getRuntimeVersionCheck(language common.ProgrammingLanguage) RuntimeVersionC
 		return &NginxVersionCheck{}
 	case common.MySQLProgrammingLanguage:
 		return &MySQLVersionCheck{}
+	case common.UnknownProgrammingLanguage:
+		return &UnknownVersionCheck{}
+	case common.IgnoredProgrammingLanguage:
+		return &IgnoredVersionCheck{}
 	default:
 		return nil
 	}

instrumentor/controllers/utils/versionsupport/language_version_support_test.go

@@ -1,10 +1,11 @@
 package versionsupport
 
 import (
+	"testing"
+
 	"github.com/odigos-io/odigos/api/odigos/v1alpha1"
 	"github.com/odigos-io/odigos/common"
 	"github.com/stretchr/testify/assert"
-	"testing"
 )
 
 func TestIsRuntimeVersionSupported_NotSupported(t *testing.T) {
@@ -21,7 +22,7 @@ func TestIsRuntimeVersionSupported_NotSupported(t *testing.T) {
 		{"python version not supported", common.PythonProgrammingLanguage, "3.7", "python runtime version not supported by OpenTelemetry SDK. Found: 3.7, supports: 3.8.0"},
 		{"nginx version not supported", common.NginxProgrammingLanguage, "1.25.4", "nginx runtime version not supported by OpenTelemetry SDK. Found: 1.25.4, supports: 1.25.5, 1.26.0"},
 		{"nginx version not supported", common.NginxProgrammingLanguage, "1.26.1", "nginx runtime version not supported by OpenTelemetry SDK. Found: 1.26.1, supports: 1.25.5, 1.26.0"},
-		{"unknown language", common.UnknownProgrammingLanguage, "0.0.0", "Unsupported language: unknown"},
+		// {"unknown language", common.UnknownProgrammingLanguage, "0.0.0", "Unsupported language: unknown"},
 	}
 
 	for _, tc := range testCases {

instrumentor/controllers/utils/versionsupport/unknown_support.go

@@ -0,0 +1,15 @@
+package versionsupport
+
+import "github.com/hashicorp/go-version"
+
+type UnknownVersionCheck struct{}
+
+func (g UnknownVersionCheck) IsVersionSupported(version *version.Version) bool {
+	// if we return false here, it will fail all device injection into all containers in the pod.
+	// we return true here, which anyhow will not inject any device into the container.
+	return true
+}
+
+func (g UnknownVersionCheck) GetSupportedVersion() string {
+	return ""
+}