Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: java doc #1518

Merged
merged 5 commits into from
Sep 19, 2024
Merged

feat: java doc #1518

merged 5 commits into from
Sep 19, 2024

Conversation

yodigos
Copy link
Contributor

@yodigos yodigos commented Sep 18, 2024

No description provided.

@edeNFed
Copy link
Contributor

edeNFed commented Sep 18, 2024

Did you see https://docs.odigos.io/instrumentations/java/ebpf ?
Maybe a better title for the page would be Native instrumentation (under Java) because we have two kind of Java instrumentation

Copy link
Collaborator

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yodigos

Left few comment

docs/instrumentations/java/java.mdx Show resolved Hide resolved
@@ -0,0 +1,76 @@
---
title: "Java Native Instrumentation"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think perhaps we can add a short paragraph to explain it, so users can easily figure out which java documentation is relevant to their setup

docs/instrumentations/java/java.mdx Show resolved Hide resolved
docs/instrumentations/java/java.mdx Outdated Show resolved Hide resolved
docs/instrumentations/java/java.mdx Outdated Show resolved Hide resolved
@@ -11,7 +11,7 @@ Odigos will automatically apply instrumentation to your selected workloads to co
Odigos provides automatic instrumentations in kubernetes for the following runtimes:

- [Go](/instrumentations/golang/golang) versions >= 1.17
- Java versions >= 17
- Java versions >= 8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Java versions >= 8
- [Java](/instrumentations/java/java)versions >= 8

docs/mint.json Outdated Show resolved Hide resolved
@yodigos yodigos enabled auto-merge (squash) September 19, 2024 11:52
@yodigos yodigos merged commit 16f6ba1 into odigos-io:main Sep 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants